Fix newer cubes sorting by version in RDF query #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bprusinowski
changed the title
ptbrowne
reviewed
Feb 18, 2022
| a.out(ns.schema.version)?.value, | ||
| b.out(ns.schema.version)?.value | ||
| +a.out(ns.schema.version)?.value!, | ||
| +b.out(ns.schema.version)?.value! |
There was a problem hiding this comment.
Did not know about this technique of using unary plus to parse the string to a number. I had to look it up the diff vs parseFloat. 👍
ptbrowne
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #348.
a.out(ns.schema.version)?.valuehad a string type, so cube 9 would be considered as more recent than cube 10. This PR fixes the issue in one of the homepage examples.